Nucleus Core

Attached to Project— Nucleus Core
Opened by Wouter Demuynck (karma) - Friday, 19 August 2005, 06:45PM

Task Type	Bug
Category	Admin Area
Status	CLOSED
Assigned To	No-one
Operating System	All

Severity	Low
Priority	Normal
Reported Version	CVS
Due in Version	3.22
Due Date	Undecided
Percent Complete

Details Info from Andrew Black:

've been working on a revised version of the ExtAuth functionality,
and I noticed a couple of minor bugs. I don't know if they're worth
a ticket, but they should probably be fixed.

The first one is in ADMIN::action_changemembersettings()
The problem is the ordering of the call to
NucleusPlugin::_applyPluginOptions and the changed email check.
Additionally, the changed email check shouldn't logout if the user
doing the edit isn't the one being edited

--- ADMIN.php Mon Aug 15 12:50:12 2005
+++ ADMIN-fix.php Mon Aug 15 20:26:34 2005
@@ -1838,22 +1838,22 @@

$mem->write();

+ // store plugin options
+ $aOptions = requestArray('plugoption');
+ NucleusPlugin::_applyPluginOptions($aOptions);
+
$manager->notify('PostPluginOptionsUpdate',array('context' =>
'member', 'memberid' => $memberid, 'member' => &$mem));
+
// if email changed, generate new password
if ($oldEmail != $mem->getEmail())
{
$mem->sendActivationLink('addresschange', $oldEmail);
// logout member
$mem->newCookieKey();
- $member->logout();
+ if ($member->getID() == $memberid)
+ $member->logout();
$this->action_login(_MSG_ACTIVATION_SENT, 0);
return;
}
-
-
- // store plugin options
- $aOptions = requestArray('plugoption');
- NucleusPlugin::_applyPluginOptions($aOptions);
-
$manager->notify('PostPluginOptionsUpdate',array('context' =>
'member', 'memberid' => $memberid, 'member' => &$mem));

if ( ( $mem->getID() == $member->getID() )
&& ( $newpass || ( $mem->getDisplayName() !=
$member->getDisplayName() ) )